Skip to content
This repository was archived by the owner on Oct 21, 2026. It is now read-only.

fix: type widening to match gapic, and two typing fixes - #2020

Merged
feywind merged 10 commits into
mainfrom
gh1707-uint8array
Mar 27, 2025
Merged

feywind merged 10 commits into
mainfrom
gh1707-uint8array

Conversation

@feywind

@feywind feywind commented Mar 26, 2025

Copy link
Copy Markdown
Contributor

Fixes #1707

@feywind
feywind requested review from a team March 26, 2025 20:19
@product-auto-label product-auto-label Bot added size: s Pull request size is small. api: pubsub Issues related to the googleapis/nodejs-pubsub API. labels Mar 26, 2025
@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 26, 2025
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Mar 26, 2025
@leahecole

Copy link
Copy Markdown

To fix CI you might have to pin to an earlier version of promisify until you upgrade to node 18 - there was an accidental minor version bump that should have been a major so 4.0.0 is safe

@generated-files-bot

Copy link
Copy Markdown

Warning: This pull request is touching the following templated files:

@feywind

feywind commented Mar 27, 2025

Copy link
Copy Markdown
Contributor Author

To fix CI you might have to pin to an earlier version of promisify until you upgrade to node 18 - there was an accidental minor version bump that should have been a major so 4.0.0 is safe

Yeah, I've been using 18 for local testing, which is probably premature. Hopefully we'll get the 18 support sorted soon on this repo, anyhow.

@feywind feywind added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2025
@gcf-owl-bot gcf-owl-bot Bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 27, 2025
@feywind
feywind merged commit 9cd73b3 into main Mar 27, 2025
@feywind
feywind deleted the gh1707-uint8array branch March 27, 2025 19:12
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: pubsub Issues related to the googleapis/nodejs-pubsub API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change type Buffer into Uint8Array in publishMessage

3 participants

⌂ 换网址