Repository navigation
Commit 5e26ba8
authored
fix(bigquery): validate universe domain on resumable upload RPCs (#15133)
Problem: `HttpBigQueryRpc.openSkipExceptionTranslation` and
`writeSkipExceptionTranslation` omitted `validateRPC()`, allowing
resumable upload requests with mismatched universe domain credentials to
bypass client-side universe domain validation.
Solution: Call `validateRPC()` at the start of both methods and add unit
tests verifying mismatched universe domain rejection before any HTTP
request is executed.
b/5888875721 parent e628795 commit 5e26ba8
2 files changed
Lines changed: 87 additions & 0 deletions
File tree
- java-bigquery/google-cloud-bigquery/src
- main/java/com/google/cloud/bigquery/spi/v2
- test/java/com/google/cloud/bigquery/spi/v2
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1975 | 1975 | | |
1976 | 1976 | | |
1977 | 1977 | | |
| 1978 | + | |
1978 | 1979 | | |
1979 | 1980 | | |
1980 | 1981 | | |
| |||
2011 | 2012 | | |
2012 | 2013 | | |
2013 | 2014 | | |
| 2015 | + | |
2014 | 2016 | | |
2015 | 2017 | | |
2016 | 2018 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
46 | 46 | | |
47 | 47 | | |
48 | 48 | | |
| 49 | + | |
49 | 50 | | |
50 | 51 | | |
51 | 52 | | |
| |||
1814 | 1815 | | |
1815 | 1816 | | |
1816 | 1817 | | |
| 1818 | + | |
| 1819 | + | |
| 1820 | + | |
| 1821 | + | |
| 1822 | + | |
| 1823 | + | |
| 1824 | + | |
| 1825 | + | |
| 1826 | + | |
| 1827 | + | |
| 1828 | + | |
| 1829 | + | |
| 1830 | + | |
| 1831 | + | |
| 1832 | + | |
| 1833 | + | |
| 1834 | + | |
| 1835 | + | |
| 1836 | + | |
| 1837 | + | |
| 1838 | + | |
| 1839 | + | |
| 1840 | + | |
| 1841 | + | |
| 1842 | + | |
| 1843 | + | |
| 1844 | + | |
| 1845 | + | |
| 1846 | + | |
| 1847 | + | |
| 1848 | + | |
| 1849 | + | |
| 1850 | + | |
| 1851 | + | |
| 1852 | + | |
| 1853 | + | |
| 1854 | + | |
| 1855 | + | |
| 1856 | + | |
| 1857 | + | |
| 1858 | + | |
| 1859 | + | |
| 1860 | + | |
| 1861 | + | |
| 1862 | + | |
| 1863 | + | |
| 1864 | + | |
| 1865 | + | |
| 1866 | + | |
| 1867 | + | |
| 1868 | + | |
| 1869 | + | |
| 1870 | + | |
| 1871 | + | |
| 1872 | + | |
| 1873 | + | |
| 1874 | + | |
| 1875 | + | |
| 1876 | + | |
| 1877 | + | |
| 1878 | + | |
| 1879 | + | |
| 1880 | + | |
| 1881 | + | |
| 1882 | + | |
| 1883 | + | |
| 1884 | + | |
| 1885 | + | |
| 1886 | + | |
| 1887 | + | |
| 1888 | + | |
| 1889 | + | |
| 1890 | + | |
| 1891 | + | |
| 1892 | + | |
| 1893 | + | |
| 1894 | + | |
| 1895 | + | |
| 1896 | + | |
| 1897 | + | |
| 1898 | + | |
| 1899 | + | |
| 1900 | + | |
| 1901 | + | |
1817 | 1902 | | |
0 commit comments