Skip to content

feat(datastore): Multi DB support - #8276

Merged
bhshkh merged 9 commits into
googleapis:mainfrom
bhshkh:feature-datastore-multi-db
Jul 26, 2023
Merged

bhshkh merged 9 commits into
googleapis:mainfrom
bhshkh:feature-datastore-multi-db

Conversation

@bhshkh

@bhshkh bhshkh commented Jul 18, 2023 •

Copy link
Copy Markdown
Contributor

b/288335209

@bhshkh
bhshkh requested review from a team July 18, 2023 00:55
@product-auto-label product-auto-label Bot added size: m Pull request size is medium. api: datastore Issues related to the Datastore API. labels Jul 18, 2023
@bhshkh
bhshkh requested a review from enocom July 18, 2023 18:05
@bhshkh
bhshkh enabled auto-merge (squash) July 20, 2023 00:44
Comment thread datastore/client.go Resolved
Comment thread datastore/datastore.go Resolved
Comment thread datastore/datastore.go Resolved
Comment thread datastore/integration_test.go Resolved
Comment thread datastore/datastore_test.go Resolved
@bhshkh
bhshkh requested a review from enocom July 21, 2023 19:22
Comment thread internal/kokoro/continuous.sh Resolved
@bhshkh
bhshkh disabled auto-merge July 24, 2023 21:57
@bhshkh
bhshkh enabled auto-merge (squash) July 24, 2023 21:57
@bhshkh
bhshkh requested a review from kolea2 July 24, 2023 21:58

@kolea2 kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just have one question

Comment thread datastore/integration_test.go Resolved

@kolea2 kolea2 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry one last nit

Comment thread datastore/client.go Resolved
@bhshkh bhshkh self-assigned this Jul 26, 2023

@noahdietz noahdietz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approval for kokoro script change.

@bhshkh
bhshkh merged commit e4d07a0 into googleapis:main Jul 26, 2023
@bhshkh
bhshkh deleted the feature-datastore-multi-db branch July 26, 2023 23:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: datastore Issues related to the Datastore API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址