Skip to content

feat(spanner): add databoost property for batch transactions - #8152

Merged
harshachinta merged 4 commits into
googleapis:mainfrom
harshachinta:federation-m2-feature
Jun 20, 2023
Merged

harshachinta merged 4 commits into
googleapis:mainfrom
harshachinta:federation-m2-feature

Conversation

@harshachinta

@harshachinta harshachinta commented Jun 19, 2023 •

Copy link
Copy Markdown
Contributor

Adding support for databoost enabled in PartitionedRead and PartitionedQuery

@harshachinta
harshachinta requested review from a team June 19, 2023 19:29
@product-auto-label product-auto-label Bot added the size: m Pull request size is medium. label Jun 19, 2023
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label Jun 19, 2023

@gauravpurohit06 gauravpurohit06 left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Can we just re-check why the integration tests are passing ?

Comment thread spanner/batch.go Resolved
Comment thread spanner/batch.go Resolved
@harshachinta
harshachinta requested review from gauravpurohit06 and olavloite and removed request for gauravpurohit06 June 20, 2023 05:41
Comment thread spanner/transaction.go Resolved
Comment thread spanner/transaction.go
if opts.RequestTag != "" {
merged.RequestTag = opts.RequestTag
}
if opts.DataBoostEnabled {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm.... This means that you cannot override a false value in ro. I guess that is OK, as we don't allow 'unsetting' any of the other values through this method either. (No action needed, just thinking out loud....)

Comment thread spanner/transaction.go Resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API. size: m Pull request size is medium.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址