Skip to content

feat(bigtable): update admin.go to support instance edition - #14479

Merged
bhshkh merged 6 commits into
googleapis:mainfrom
NickASC4:main
Apr 29, 2026
Merged

bhshkh merged 6 commits into
googleapis:mainfrom
NickASC4:main

Conversation

@NickASC4

Copy link
Copy Markdown
Contributor

Adding support for new Editions type in admin.go

@NickASC4
NickASC4 requested review from a team as code owners April 23, 2026 19:45
@product-auto-label product-auto-label Bot added the api: bigtable Issues related to the Bigtable API. label Apr 23, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Bigtable instance editions by adding an Edition field to configuration structs and updating administrative methods. Feedback highlights that while CreateInstanceWithClusters was updated, the CreateInstance method seems to have been overlooked despite being used in new tests. Additionally, a more idiomatic Go comparison is suggested for the edition check in the update logic.

Comment thread bigtable/admin.go Resolved
Comment thread bigtable/admin.go Resolved

@bhshkh bhshkh left a comment •

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please modify an existing integration test.

Please fix vet failure "Error: bigtable/admin.go:1379:2: exported const Enterprise should have comment (or a comment on this block) or be unexported".

Please resolve review comment from gemini code assist.

@bhshkh
bhshkh enabled auto-merge (squash) April 28, 2026 18:09
@bhshkh bhshkh added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2026
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 28, 2026
@bhshkh bhshkh added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2026
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 29, 2026
@bhshkh
bhshkh merged commit cf1153d into googleapis:main Apr 29, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the Bigtable API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants

⌂ 换网址