Repository navigation
feat(bigtable): update admin.go to support instance edition - #14479
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for Bigtable instance editions by adding an Edition field to configuration structs and updating administrative methods. Feedback highlights that while CreateInstanceWithClusters was updated, the CreateInstance method seems to have been overlooked despite being used in new tests. Additionally, a more idiomatic Go comparison is suggested for the edition check in the update logic.
bhshkh
approved these changes
Apr 23, 2026
bhshkh
requested changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Please modify an existing integration test.
Please fix vet failure "Error: bigtable/admin.go:1379:2: exported const Enterprise should have comment (or a comment on this block) or be unexported".
Please resolve review comment from gemini code assist.
bhshkh
approved these changes
Apr 27, 2026
bhshkh
enabled auto-merge (squash)
April 28, 2026 18:09
hongalex
approved these changes
Apr 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding support for new Editions type in admin.go