Skip to content

fix(spanner): use spanner options when initializing monitoring exporter - #11109

Merged
rahul2393 merged 6 commits into
mainfrom
use-spanner-opts-in-monitoring
Nov 12, 2024
Merged

rahul2393 merged 6 commits into
mainfrom
use-spanner-opts-in-monitoring

Conversation

@rahul2393

Copy link
Copy Markdown
Contributor

@rahul2393
rahul2393 requested review from a team, harshachinta and olavloite November 9, 2024 05:42
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label Nov 9, 2024

@olavloite olavloite left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change LGTM, but can we add a test that fails without this change, and succeeds with it? Or is that for some reason not possible?

Comment thread spanner/metrics.go Resolved
@rahul2393
rahul2393 requested a review from olavloite November 12, 2024 06:51
@rahul2393
rahul2393 force-pushed the use-spanner-opts-in-monitoring branch from 02f989c to 0903a4a Compare November 12, 2024 07:27
Comment thread spanner/metrics_monitoring_exporter.go Resolved
@rahul2393
rahul2393 force-pushed the use-spanner-opts-in-monitoring branch from c13b30f to 3b31f22 Compare November 12, 2024 16:44
@rahul2393
rahul2393 merged commit 81413f3 into main Nov 12, 2024
@rahul2393
rahul2393 deleted the use-spanner-opts-in-monitoring branch November 12, 2024 17:04
gcf-merge-on-green Bot pushed a commit that referenced this pull request Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址