Repository navigation
fix(datastore): regenerate protos in new namespace - #10158
Conversation
The namespace and filename need to be different than the file these were copied and regenerated from to make the proto registry not error out on initialization. Fixes: googleapis#10155
|
While this would fix it, it is also risky. Would it be possible to do a little more brainstorming before pressing the button? |
For sure. I did look at that page before I made the change. I think this should all be safe and non-breaking for from my read. It is not ideal though. In a perfect world those protos would be central defined somewhere and we would import reference them in both places. It should also be noted that it really valid to use this library in appengine standard according to the docs: https://cloud.google.com/appengine/docs/legacy/standard/go111/datastore#connecting_to_with_app_engine
And in flex I don't think there is value in using the app engine package, that was designed for standard: https://github.com/golang/appengine?tab=readme-ov-file#upgrading-an-app-engine-app-to-the-flexible-environment |
So is this a feature? 😛 Ok I've reviewed the usage in |
The namespace and filename need to be different than the file these were copied and regenerated from to make the proto registry not error out on initialization.
Usually it is not good to use a new package name in protos but I believe it is fine here since these are just simple message types being declared and not a service.
Fixes: #10155