Skip to content

fix(spanner): wait for background goroutines to complete - #10095

Merged
rahul2393 merged 4 commits into
googleapis:mainfrom
egonelbre:fixrace
Aug 21, 2024
Merged

rahul2393 merged 4 commits into
googleapis:mainfrom
egonelbre:fixrace

Conversation

@egonelbre

@egonelbre egonelbre commented May 3, 2024 •

Copy link
Copy Markdown
Contributor

As a good rule of thumb every single goroutine needs to be waited to be completed, otherwise it's easy to introduce issues where the created goroutine outlives the parent and accesses variables or services that have been shutdown.

Fixes #10324

@egonelbre
egonelbre requested review from a team May 3, 2024 09:56
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label May 3, 2024
As a good rule of thumb every single goroutine needs to be waited
to be completed, otherwise it's easy to introduce issues where the
created goroutine outlives the parent and accesses variables or
services that have been shutdown.
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 5, 2024
@codyoss

codyoss commented Jul 24, 2024

Copy link
Copy Markdown
Member

@rahul2393 can we merge this?

@egonelbre

Copy link
Copy Markdown
Contributor Author

@rahul2393 can this be merged?

@rahul2393
rahul2393 enabled auto-merge (squash) August 21, 2024 15:09
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Aug 21, 2024
@rahul2393
rahul2393 merged commit 7785cad into googleapis:main Aug 21, 2024
@egonelbre
egonelbre deleted the fixrace branch August 22, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

spanner: background goroutines are left running

4 participants

⌂ 换网址