Repository navigation
Fix races in shim version queries and RPC shutdown - #14358
Merged
copybara-service[bot] merged 1 commit intoSep 16, 2026
Merged
Conversation
Contributor
Author
|
r? @fvoznika for shim snapshots, unlocked URPC stopper callbacks and port-forward fixture ownership. The cumulative diff is 8 files (+292/−197), centered on Assisted-by: Codex |
tamird
force-pushed
the
checklocks-control-fixes
branch
from
September 3, 2026 21:31
1d68980 to
df401f0
Compare
parth-opensrc
approved these changes
Sep 4, 2026
Contributor
Author
|
@parth-opensrc I see there are some failures on the import PR but I can't see what they are. Is there any action required here? |
copybara-service Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Snapshot the configured runtime command and registered RPC stoppers under their mutexes, then execute the command and stopper callbacks after unlocking. Repair port-forward fixture synchronization, buffer ownership, short-read handling, and cleanup. Replace the existing close-order test’s sleep with explicit synchronization. Assisted-by: Codex FUTURE_COPYBARA_INTEGRATE_REVIEW=#14358 from tamird:checklocks-control-fixes df401f0 PiperOrigin-RevId: 976100909
copybara-service Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Snapshot the configured runtime command and registered RPC stoppers under their mutexes, then execute the command and stopper callbacks after unlocking. Repair port-forward fixture synchronization, buffer ownership, short-read handling, and cleanup. Replace the existing close-order test’s sleep with explicit synchronization. Assisted-by: Codex FUTURE_COPYBARA_INTEGRATE_REVIEW=#14358 from tamird:checklocks-control-fixes df401f0 PiperOrigin-RevId: 976100909
copybara-service Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
Snapshot the configured runtime command and registered RPC stoppers under their mutexes, then execute the command and stopper callbacks after unlocking. Repair port-forward fixture synchronization, buffer ownership, short-read handling, and cleanup. Replace the existing close-order test’s sleep with explicit synchronization. Assisted-by: Codex FUTURE_COPYBARA_INTEGRATE_REVIEW=#14358 from tamird:checklocks-control-fixes df401f0 PiperOrigin-RevId: 976100909
Member
|
@tamird please squash your commits into one for the PR. Otherwise, we can't import and merge this change |
milantracy
self-requested a review
September 9, 2026 18:21
tamird
force-pushed
the
checklocks-control-fixes
branch
from
September 9, 2026 18:58
df401f0 to
9db8cde
Compare
Contributor
Author
|
@milantracy done. |
milantracy
approved these changes
Sep 9, 2026
tamird
force-pushed
the
checklocks-control-fixes
branch
2 times, most recently
from
September 9, 2026 22:04
41bb56f to
89b2992
Compare
Publish a copy of the configured runsc command atomically when the sandbox is created. Version reads it without racing with updates or waiting for container creation. Preserve the default command before creation and when the configured command is empty. Remove the unused shim root field. Snapshot registered RPC stoppers under their mutex and run callbacks after unlocking, so callbacks can reenter the server. Synchronize port-forward test waiters and return owned buffers. Handle short reads and fixture cleanup, and coordinate the close-order test without sleeps. Assisted-by: Codex
tamird
force-pushed
the
checklocks-control-fixes
branch
from
September 9, 2026 22:08
89b2992 to
6ca77eb
Compare
Contributor
Author
|
@milantracy looks like this failed to import, does it need the ready to pull label? |
parth-opensrc
approved these changes
Sep 16, 2026
copybara-service Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
Snapshot the configured runtime command and registered RPC stoppers under their mutexes, then execute the command and stopper callbacks after unlocking. Repair port-forward fixture synchronization, buffer ownership, short-read handling, and cleanup. Replace the existing close-order test’s sleep with explicit synchronization. Assisted-by: Codex FUTURE_COPYBARA_INTEGRATE_REVIEW=#14358 from tamird:checklocks-control-fixes 6ca77eb PiperOrigin-RevId: 976100909
copybara-service Bot
pushed a commit
that referenced
this pull request
Sep 16, 2026
Snapshot the configured runtime command and registered RPC stoppers under their mutexes, then execute the command and stopper callbacks after unlocking. Repair port-forward fixture synchronization, buffer ownership, short-read handling, and cleanup. Replace the existing close-order test’s sleep with explicit synchronization. Assisted-by: Codex FUTURE_COPYBARA_INTEGRATE_REVIEW=#14358 from tamird:checklocks-control-fixes 6ca77eb PiperOrigin-RevId: 976100909
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Version needs the configured runsc binary while sandbox creation is in progress. Publish a copy of the command through an atomic pointer so the version probe neither races with updates nor waits for the service mutex held during creation. Use the default binary when the command is unset or empty, and remove the unused shim root field.
Snapshot registered RPC stoppers under their mutex, then invoke callbacks after unlocking so callbacks can reenter the server.
Repair port-forward fixture synchronization, buffer ownership, short-read handling, and cleanup. Replace the close-order test's sleep with explicit synchronization.
Assisted-by: Codex