Skip to content

#788 jpa: Object-methods like finalize become transactional, if the Type is annotated Transactional - #958

Closed
andresviedma wants to merge 1 commit into
google:masterfrom
andresviedma:transactional-object-methods
Closed

andresviedma wants to merge 1 commit into
google:masterfrom
andresviedma:transactional-object-methods

Conversation

@andresviedma

Copy link
Copy Markdown
Contributor

I had the problem described in the issue too. The thing is that when a class is annotated as Transactional, the methods of its superclasses shouldn't be considered transactional. The most serious problem comes with Object methods, and especially finalize. I've fixed that, checking that the method class has the annotation, instead of the class of the called object.

I've also created a "lenient" mode, so that if anyone was using the interceptor in some strange way with no real Transactional annotational attached, it keeps working. But the normal behaviour configured in the module is to be not lenient (strict).

@googlebot

Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@andresviedma

Copy link
Copy Markdown
Contributor Author

I signed it!

@googlebot

Copy link
Copy Markdown

CLAs look good, thanks!

@andresviedma

Copy link
Copy Markdown
Contributor Author

Hi! Is anyone reviewing the pull requests? This PR is already 6 months old...

copybara-service Bot pushed a commit that referenced this pull request Apr 21, 2023
copybara-service Bot pushed a commit that referenced this pull request Apr 21, 2023
copybara-service Bot pushed a commit that referenced this pull request Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

⌂ 换网址