Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-openapi/validate
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.26.4
Choose a base ref
...
head repository: go-openapi/validate
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.26.5
Choose a head ref
  • 7 commits
  • 6 files changed
  • 2 contributors

Commits on Aug 25, 2026

  1. test(messages): halt on the first failing fixture only in dev mode

    Both Test_MessageQuality*_Issue44 passed haltOnErrors=true, while testWalkSpecs
    runs every fixture with t.Parallel(). checkMustHalt therefore stopped the run on
    whichever fixture lost the race and the rest were never reported, so the fixture
    named in the failure changed from run to run.
    
    haltOnErrors now follows DebugTest, which already decides whether the fixtures
    run serially. A normal run reports every failing fixture; a run with
    SWAGGER_DEBUG_TEST=1 still stops at the first one, serially, which is what that
    mode is for.
    
    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi and claude committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    ce91d00 View commit details
    Browse the repository at this point in the history
  2. test(messages): add TestGenExpectations to rebuild the expectations file

    expected_messages.yaml pins some 700 messages over 50 fixtures and had no way to
    be re-derived, so it drifted: the -enable-long lane has been red since v0.23.0,
    growing from 7 failing fixtures to 17.
    
    TestGenExpectations runs every fixture through the validator in both modes and
    rewrites the file. It edits the yaml.Node tree rather than re-marshalling the
    document, so the 48 comments in the file survive: an expectation that still
    matches keeps its node and its spelling, one that matches nothing is deleted, an
    actual message nothing covers is appended, and withContinueOnErrors is set from
    whether the message also appears in the stop-on-errors run.
    
    It skips unless SWAGGER_GEN is set, and running it twice changes nothing.
    
    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi and claude committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    e83999e View commit details
    Browse the repository at this point in the history
  3. test(messages): refresh expected_messages.yaml from the validators

    The messages now name the parameter they are about - "parameters.0.in" in the
    stop-on-errors run and "parameters.myid.in" in the continue-on-errors one, where
    the file still expected "parameters.in" - and example validation reports
    warnings that did not exist when the file was written. Regenerated with
    TestGenExpectations. The two "could not resolve reference" expectations were
    widened by hand for the "cannot load spec:" prefix loads now adds, rather than
    replaced by a literal carrying an absolute path.
    
    Three fixtures record a defect instead of a message, each with a todo saying so:
    
    - fixture-581.yaml and fixture-additional-items-3.yaml no longer load at all,
      and have not since v0.23.0, so both now expect a load error. The first spells
      "maximum: 18446744073709551615", a YAML integer beyond int64, which the
      conversion refuses; the second spells "properties: {v: string}", which is not
      a schema and spec.Schema refuses. Both were written to exercise validation and
      reach no validator today. What fixture-581.yaml now demonstrates is the
      unmarshalling error itself, which names the offending value but not the field
      it came from.
    - fixture-constraints-on-numbers.yaml does not report "param3 in query should be
      a multiple of 10", though the fixture's own comment says it should. MultipleOf
      compares data/factor through conv.IsFloat64AJSONInteger, whose tolerance is
      relative: at a quotient of 2.1e8 it accepts a remainder up to 0.2, and
      2147483648/10 = 214748364.8 falls inside that. MultipleOfInt and MultipleOfUint
      decide the same numbers correctly, so only a value arriving as a float64 is
      affected. The todo says why this is not a tolerance to retune: multipleOf is
      only decidable with decimal arithmetic.
    
    The -enable-long lane is green.
    
    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi and claude committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    da10635 View commit details
    Browse the repository at this point in the history
  4. ci: re-instate error message stability test in ci

    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    ab4461e View commit details
    Browse the repository at this point in the history
  5. Merge pull request #292 from fredbi/fix/message-quality-expectations

    Fix/message quality expectations
    fredbi authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    07d44fe View commit details
    Browse the repository at this point in the history
  6. fix: onboard spec url normalization fix (#293)

    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    251c9c5 View commit details
    Browse the repository at this point in the history
  7. fix: onboards loads fixes

    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    a214a69 View commit details
    Browse the repository at this point in the history
Loading
⌂ 换网址