Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: go-openapi/spec
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.22.10
Choose a base ref
...
head repository: go-openapi/spec
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.22.11
Choose a head ref
  • 4 commits
  • 7 files changed
  • 2 contributors

Commits on Aug 25, 2026

  1. chore(deps): bump jsonreference to v1.0.1 and swag to v0.29.1

    jsonreference v1.0.1 stops NormalizeURL from turning a parseable URI into an
    unparseable one: "https://:a:443" used to come back as "https://:a", where ":a"
    is not a valid port.
    
    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi and claude committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    d9388db View commit details
    Browse the repository at this point in the history
  2. fix(normalizer): align $ref and base canonicalization with jsonreference

    The normalizer kept the spelling it was handed, while jsonreference lower-cases
    the host, drops a default port and re-escapes path and fragment. Both meet every
    $ref - the normalizer builds the URI, and jsonreference re-renders it as soon as
    the string becomes a Ref - so one document could be cached under two spellings
    of itself, and a $ref written back by denormalizeRef did not normalize to what
    it came from.
    
    normalizeURI and normalizeBase now end in canonicalString, which renders through
    NewRef. Only the branch returning a $ref that is already canonical and the two
    returns of normalizeBase were spelling their own answer; a relative $ref went
    through the join onto the base, which already re-rendered. A URI jsonreference
    cannot parse is returned as it stands and logged, rather than panicking through
    MustCreateRef.
    
    forgetSpelling drops url.URL.RawPath and RawFragment once Path has been rewritten
    by path.Clean or by the join. String returns RawPath whenever it still decodes to
    Path, so a stale one could be rendered instead: normalizeBase("%2F") returned
    "file://%2F", where the escaped form has no leading slash and what is left reads
    as an authority - a base that no longer parses.
    
    FuzzNormalizer drops the respelled() fence its fourth property carried, so
    denormalizing now has to round-trip for every input rather than for those the two
    sides happened to spell alike. 9.6M executions clean. TestNormalizer_Canonicalization
    and TestNormalizer_CanonicalBase pin the rules case by case, including the
    degenerate authorities, the runs of slashes and the escaping.
    
    One rule is recorded rather than fixed, in TestNormalizer_EscapedSlashIsDecoded:
    jsonreference decodes %2F into a separator, which RFC 3986 section 6.2.2.2 forbids. A
    $ref loses the escape anyway when the document model turns it into a Ref, so
    keeping it in the normalizer would only hide that. It belongs upstream.
    
    Also drops the parentheses in expander.go that gofumpt flags, untouched since
    2021, so a full golangci-lint run comes out clean.
    
    Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    fredbi and claude committed Aug 25, 2026
    Configuration menu
    Copy the full SHA
    18354e0 View commit details
    Browse the repository at this point in the history
  3. Merge pull request #308 from fredbi/fix/align-url-normalization

    Fix/align url normalization
    fredbi authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    34af4e1 View commit details
    Browse the repository at this point in the history
  4. test(normalizer): fix the escaped-path base case failing on windows (#…

    …309)
    
    TestNormalizer_CanonicalBase/escaped_path_rendering expected normalizeBase("%2F")
    to be "file:///". A base carrying no scheme is anchored to the working directory,
    so on windows it comes out as "file:///d:", or whichever drive the tests run from.
    
    The case moves out of the table into TestNormalizer_EscapedPathRendering, which
    compares normalizeBase("%2F") against normalizeBase("/") rather than a literal:
    both spell the root and both are anchored the same way, on either platform. It
    also asserts what the defect actually was, that the result is neither
    "file://%2F" nor something parseURL rejects.
    
    Signed-off-by: Frederic BIDON <fredbi@yahoo.com>
    Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
    fredbi and claude authored Aug 25, 2026
    Configuration menu
    Copy the full SHA
    69a6c4c View commit details
    Browse the repository at this point in the history
Loading
⌂ 换网址