Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: folbricht/desync
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.2
Choose a base ref
...
head repository: folbricht/desync
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.3
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Jun 11, 2026

  1. Use testing/synctest in dedup queue tests (#357)

    Run TestDedupQueueParallel and TestWriteDedupQueueParallelReadWrite
    inside synctest bubbles. The fake clock makes the previously
    timing-dependent behavior deterministic:
    
    - TestDedupQueueParallel: the sleep in GetChunkFunc now guarantees all
      goroutines have registered as waiters before the first request
      completes, so the assertion can require exactly one upstream request
      instead of "ideally just one".
    
    - TestWriteDedupQueueParallelReadWrite: the test now asserts that no
      fake time elapses across StoreChunk(), proving the write does not
      queue behind the in-flight slow read. The 1s sleep no longer costs
      wall time and the background read goroutine no longer leaks past the
      test.
    folbricht authored Jun 11, 2026
    Configuration menu
    Copy the full SHA
    86eb6d0 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2026

  1. Fix GCS not-found detection to unwrap ErrObjectNotExist (#358) (#359)

    cloud.google.com/go/storage v1.60.0 (bumped from v1.30.1 in a452c77)
    now wraps storage.ErrObjectNotExist via formatObjectErr instead of
    returning the bare sentinel. The direct equality checks
    (err == storage.ErrObjectNotExist) in GetChunk and HasChunk therefore
    no longer match, so expected cache misses are misclassified as fatal
    errors. This made "desync make" abort with "storage: object doesn't
    exist: googleapi: Error 404: No such object" when storing a new chunk.
    
    Use errors.Is, which unwraps, in all three locations.
    folbricht authored Jun 18, 2026
    Configuration menu
    Copy the full SHA
    f67d01e View commit details
    Browse the repository at this point in the history
Loading
⌂ 换网址