Skip to content

fix: allow to unlink providers only in edit mode - #10649

Merged
russellwheatley merged 3 commits into
masterfrom
fix/ui-unlink-provider
Apr 4, 2023
Merged

russellwheatley merged 3 commits into
masterfrom
fix/ui-unlink-provider

Conversation

@lesnitsky

Copy link
Copy Markdown
Contributor

Related Issues

Closes #10623

Checklist

Before you create this PR confirm that it meets all requirements listed below by checking the relevant checkboxes ([x]).
This will ensure a smooth and quick review process. Updating the pubspec.yaml and changelogs is not required.

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • My PR includes unit or integration tests for all changed/updated/fixed behaviors (See Contributor Guide).
  • All existing and new tests are passing.
  • I updated/added relevant documentation (doc comments with ///).
  • The analyzer (melos run analyze) does not report any problems on my PR.
  • I read and followed the Flutter Style Guide.
  • I signed the CLA.
  • I am willing to follow-up on review comments in a timely manner.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

@lesnitsky
lesnitsky requested review from Lyokone and pr-Mais March 23, 2023 16:49
@russellwheatley
russellwheatley merged commit c2da6c7 into master Apr 4, 2023
@russellwheatley
russellwheatley deleted the fix/ui-unlink-provider branch April 4, 2023 13:26
@firebase firebase locked and limited conversation to collaborators May 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 [firebase_ui_auth] profile_screen allows unlinking of providers when not in editing mode

3 participants

⌂ 换网址