Skip to content

Commit ce18d4d

Browse files
committed
fix(home): show the source line below the refresh date
The app cell is a grid on desktop (its children come from .atv-app-text via display: contents) and a flex column on phones. The source line was pinned to grid-row: 4, which pushed the refresh date above it on desktop even though the date is the last element in the markup, so the cell read name, version, date, source there and name, version, source, date on phones. Move the date above the source line in the markup so the order comes from DOM order alone, and drop the fixed grid row. Both layouts now read name, version, optional bundle identifier, refresh date, then the tracked source, and no child can be reordered behind the markup's back. The 10px gap above the source line moves out of the min-width: 768px block so phones get it too, instead of leaving the chip tight against the date. Row heights stay identical on desktop.
1 parent 812bd79 commit ce18d4d

2 files changed

Lines changed: 21 additions & 13 deletions

File tree

‎web/static/src/app.css‎

Lines changed: 12 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -795,10 +795,20 @@ html[data-theme="dark"] {
795795
gap: 12px;
796796
}
797797

798+
/* The source line closes the app cell, below the refresh date, on every
799+
breakpoint: give it the same breathing room above it whether the cell is
800+
the desktop grid or the phone card. */
801+
.app-container .main-container .table td .atv-app-text > .atv-source-line {
802+
margin-top: 10px;
803+
}
804+
798805
/* Table layout of the installed apps (mobile.css turns them into cards): the
799-
source line sits under the app title in the same column. Tracking a source
806+
source line sits in the same column as the app title. Tracking a source
800807
then keeps the column widths, so the Device and Account cells are not
801-
squeezed. */
808+
squeezed.
809+
The app cell follows DOM order: name, version, optional bundle identifier,
810+
refresh date, then the source line. Do not pin a child to a fixed grid row:
811+
that reordered the date and split the app's identity from its status. */
802812
@media (min-width: 768px) {
803813
.app-container .main-container .table td .flex.atv-app-cell {
804814
display: grid;
@@ -820,8 +830,6 @@ html[data-theme="dark"] {
820830

821831
.app-container .main-container .table td .atv-app-text > .atv-source-line {
822832
grid-column: 2;
823-
grid-row: 4;
824-
margin-top: 10px;
825833
contain: inline-size;
826834
}
827835

‎web/static/src/page/home/index.vue‎

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -205,6 +205,15 @@
205205
>
206206
{{ item.custom_identifier }}
207207
</div>
208+
<div class="stat-title text-sm">
209+
<a
210+
class="link link-hover stat-title font-normal"
211+
:href="logUrl(item)"
212+
:title="$t('home.table.tips.view_log')"
213+
target="_blank"
214+
>{{ formatRefreshDate(item) }}</a
215+
>
216+
</div>
208217
<div class="flex flex-wrap items-center gap-1 atv-source-line">
209218
<span class="badge badge-info badge-sm max-w-full" v-if="item.source.latest_build_id">
210219
<span class="truncate">{{
@@ -228,15 +237,6 @@
228237
}}</span>
229238
</button>
230239
</div>
231-
<div class="stat-title text-sm">
232-
<a
233-
class="link link-hover stat-title font-normal"
234-
:href="logUrl(item)"
235-
:title="$t('home.table.tips.view_log')"
236-
target="_blank"
237-
>{{ formatRefreshDate(item) }}</a
238-
>
239-
</div>
240240
</div>
241241
</div>
242242
</td>

0 commit comments

Comments
 (0)
⌂ 换网址