Skip to content

Windows terminal issues caused by winpty #45693

Closed

Description

@Tyriar

This is a meta issue to act as a central place for all winpty issues.

Legend

Icon Meaning
✔️ Workaround in place
✖️ Still an issue

General

Foreground/background color

Process killing / ctrl+c

Clearing

Tasks

Windows regressions

These issues slipped into stable Windows and took month(s) to get a fix to users as a result.

Activity

  1. added
    plan-itemVS Code - planned item for upcoming
    terminalGeneral terminal issues that don't fall under another label
    windowsVS Code on Windows issues
    on Mar 13, 2018
  2. added this to the Backlog milestone on Mar 13, 2018
  3. monk-time commented on Mar 16, 2018

    @monk-time

    Shouldn't #45682 be also added to this list?

  4. Tyriar commented on Mar 16, 2018

    @Tyriar
    ContributorAuthor

    Dmitry Bogorad (@monk-time) added it to the list

  5. borekb commented on Aug 24, 2018

    @borekb

    Daniel Imms (@Tyriar) how did the initial exploration go, if there was time for any? ConPTY sounds great in theory although I'm not sure that my high hopes of replacing winpty entirely are real :)

  6. Tyriar commented on Aug 24, 2018

    @Tyriar
    ContributorAuthor

    Borek Bernard (@borekb) it's in progress (microsoft/node-pty#216), I put it on hold as we're almost testing the August build and it won't make it. It's basically working but I can't stick it in VS Code yet as I'm having build problems when compiling against VS Code's version of node. Hopefully will something we can play around with soon 😃

  7. 8 remaining items

  8. jarbus commented on Nov 14, 2018

    @jarbus

    Not sure if this is of any help, but when opening the bash terminal it additionally scrolls all the way down after highlighting the entire terminal. Killing it and opening a new terminal just goes back to the regular highlighting issue. The following image is right after opening a terminal just after opening VSCode
    image
    This is additionally on a machine that got a fresh installation of windows an hour prior.

  9. Astrantia commented on Nov 18, 2018

    @Astrantia

    Daniel Imms (@Tyriar) It didn't make into 1.29. Are you planning to release the improvements in 1.30?

    Ghislain B. (@ghiscoding) this year, I'll be working on this again next month so it will hopefully make it into 1.29.

  10. cedric05 commented on Nov 18, 2018

    @cedric05
    Contributor

    with latest fall creators update, windows is psesdo console apis. is vscode planning to use them?
    Reference: https://docs.microsoft.com/en-us/windows/console/creating-a-pseudoconsole-session
    Daniel Imms (@Tyriar)
    i want to give it a try

  11. ExE-Boss commented on Nov 18, 2018

    @ExE-Boss
    Contributor

    Prasanth (@cedric05) This is being done in microsoft/node-pty#236 (see microsoft/node-pty#216 for details).

  12. namvt13 commented on Nov 25, 2018

    @namvt13

    I was redirected here by another user, but the issue at #26375 & #47088 has also happened outside of vscode (In my case, it is the terminal of Ubuntu), so it likely to be some OS bug.

  13. Tyriar commented on Nov 26, 2018

    @Tyriar
    ContributorAuthor

    Adoption of conpty is on the way as ExE Boss (@ExE-Boss) pointed out, it's currently blocked on VS Code adopting Electron 3 #52629

  14. Astrantia commented on Nov 26, 2018

    @Astrantia

    Daniel Imms (@Tyriar) is this shipped in exploration builds if electron 3 is the blocker?

  15. SetTrend commented on Dec 14, 2018

    @SetTrend

    cls still doesn't clear scroll buffer on Windows systems. Rather annoying. Particularly when you need to search through long logs.

    https://docs.microsoft.com/en-us/windows-server/administration/windows-commands/cls
    https://docs.microsoft.com/en-us/powershell/module/microsoft.powershell.core/functions/clear-host

  16. Tyriar commented on Dec 21, 2018

    @Tyriar
    ContributorAuthor

    ConPTY support is landing in the next Insiders build, this uses a new backend for the terminal on WIndows 10 build number 17692+, this is expected to fix many bugs in the terminal on Windows as we're adopting Microsoft's official pty API. For earlier versions winpty will still be used a many bugs will still remain (unless they're fixed in that project).

    If you find any issues with conpty please report them to https://github.com/Microsoft/console (the team who own ConPTY) or this repo (if you think it's an integration issue). You can opt out of conpty by adding this setting:

    "terminal.integrated.windowsEnableConpty": false
    
  17. locked as resolved and limited conversation to collaborators on Dec 21, 2018
  18. Tyriar commented on Jan 23, 2019

    @Tyriar
    ContributorAuthor

    Update: Windows build number 18309+ is now required for ConPTY to be turned on as it was not stable on 17692.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Labels

plan-itemVS Code - planned item for upcomingterminalGeneral terminal issues that don't fall under another labelwindowsVS Code on Windows issues

Type

No type

Projects

No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions

    ⌂ 换网址